Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU]feat: qkv_attention_fusion: qk scale can be below qk_matmul #68949

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

jinmingyi1998
Copy link
Contributor

PR Category

Inference

PR Types

New features

Description

modify ir: qk scale can be below qk_matmul

add arg scale_above_qk to determine scale's position

Copy link

paddle-bot bot commented Oct 25, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 25, 2024
Copy link
Contributor

@lj970926 lj970926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RuohengMa RuohengMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04 houj04 added the XPU label Oct 28, 2024
@houj04 houj04 merged commit 30657a5 into PaddlePaddle:develop Oct 28, 2024
27 checks passed
@jinmingyi1998 jinmingyi1998 deleted the xpu_fuse_qkv_attention branch October 28, 2024 10:35
fxfxfxfxfxfxfxfx pushed a commit to fxfxfxfxfxfxfxfx/Paddle that referenced this pull request Oct 29, 2024
…ddlePaddle#68949)

* [XPU]feat: qkv_attention_fusion: qk scale can be below qk_matmul

* add xpu ir qkv attention fuse test case

* remove test skip

* add kl3 unit test, fix unit test

* update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers XPU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants