Add type_alias to import framework into ops #3048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make implement an operator less noisy.
dzhwinter
reviewed
Jul 25, 2017
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ | ||
|
|
There was a problem hiding this comment.
It seems tricky to flatten namespace in this way. But it simplifies some lines of code truly, shall we put the necessary using declaration in the head lines in every source file?
There was a problem hiding this comment.
Most operators are common about what they used. Just declare them in a common file.
If we declare them into every source file, it could be redefined error when some of them depends on each other. Like
// op_a.h
using XXX = ...;#include "a.h"
using XXX = ...; // redefined error.
reyoung
force-pushed
the
feature/add_namespace_using
branch
from
4bf1d90 to
0b4880b
Compare
Merged
reyoung
force-pushed
the
feature/add_namespace_using
branch
from
0b4880b to
ea99d71
Compare
reyoung
force-pushed
the
feature/add_namespace_using
branch
from
ea99d71 to
2463c1c
Compare
|
Merged by PR #3067 |
|
I think we should revert this PR -- it confuses users from understanding where those important classes are defined. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make implement an operator less noisy.