-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWM_MAX setting to 2200us only outputs 2150us #14105
Comments
Hi @ataits The limit is hard coded here. https://github.com/PX4/Firmware/blob/37db7d3bba965c379ac5e997661fa4930783daf3/src/drivers/drv_pwm_output.h#L101 Is this something we need to change? At the moment I'm not aware of a reason it should be 2150 us vs 2200 us. |
Correct me if I'm wrong; Not trying to discourage you from picking what value you want as you probably have good reason for doing it, but I believe the standard for drone-related PWM control is a range from 1000-2000 us... Is there a particular effect you are trying to achieve by setting it to 2200 us? |
The problem is parameter reference is not consistent with this hard coded value. It says maximum value can be set to 2200. In most cases 1000 2000 is fine for standard escs. But wider ranges can work for servo travels. Any way it doesnt make sense when hard limit is less than parameter max value. |
Agreed. Could you make a PR to fix it? Thx. |
Should I make a PR to fix this? Can we include this fix in the upcoming 1.11.0 release? |
Yes please, and I'd think that should make it in. |
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
There are always the correct default limits in the corresponding settings. In the PWM output driver, the highest degree of freedom should be set to highest max = 2500uS. |
Describe the bug
When I set the parameter PWM_MAX to 2200us, I expect that the maximum output should be 2200us. However, when I check the port0 outputs via QGC analyzer, I see only 2150us at maximum throttle (in acro mode).
To Reproduce
Steps to reproduce the behavior:
Expected behavior
PWM output should go up to 2200us at maximum throttle
*Tested on Firmware version 1.10 and 1.9
Drone
Additional context
The idea to enable full range output of 800us to 2200us. This is very important for ESC and on other platforms especially servos that can benefit from full amplitude of motion.
The text was updated successfully, but these errors were encountered: