Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update submodule matrix to latest Sat Jul 18 12:39:56 UTC 2020 #15372

Merged
merged 1 commit into from
Jul 19, 2020
Merged

Update submodule matrix to latest Sat Jul 18 12:39:56 UTC 2020 #15372

merged 1 commit into from
Jul 19, 2020

Conversation

TSC21
Copy link
Member

@TSC21 TSC21 commented Jul 18, 2020 •
edited
Loading 

- matrix in PX4/Firmware (e4d064f83076917491e3dd3bca183488e0a5f0b3): https://github.com/PX4/Matrix/commit/9a30828a0a1d79e87fd09653bb9f936d7ca0ba17
- matrix current upstream: https://github.com/PX4/Matrix/commit/0fd99c59f1740a7aa2ead03168705b4211bf29e8
- Changes:  https://github.com/PX4/Matrix/compare/9a30828a0a1d79e87fd09653bb9f936d7ca0ba17...0fd99c59f1740a7aa2ead03168705b4211bf29e8
0fd99c5 2020-07-14 Matthias Grob - Switch operator() to return a const reference
8a59b46 2020-07-17 kamilritz - Quaternion: Use template type instead of single hardcoded type

@TSC21 TSC21 requested review from kamilritz, MaEtUgR and dagar July 18, 2020 18:21
@dagar
Copy link
Member

dagar commented Jul 18, 2020

@MaEtUgR @jkflying it's pretty minor, but letting Matrix operator() return the actual value ends up being slightly cheaper.

Screenshot from 2020-07-18 14-34-17

@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/matrix branch from 0bc443a to f1bb10d Compare July 19, 2020 00:39
@weekly-digest weekly-digest bot mentioned this pull request Jul 19, 2020
Closed
@PX4BuildBot
Update submodule matrix to latest Sun Jul 19 12:40:00 UTC 2020
a786336 
    - matrix in PX4/Firmware (20d5e7a): PX4/PX4-Matrix@9a30828
    - matrix current upstream: PX4/PX4-Matrix@0fd99c5
    - Changes: PX4/PX4-Matrix@9a30828...0fd99c5

    0fd99c5 2020-07-14 Matthias Grob - Switch operator() to return a const reference
8a59b46 2020-07-17 kamilritz - Quaternion: Use template type instead of single hardcoded type
@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/matrix branch from f1bb10d to a786336 Compare July 19, 2020 12:40
@dagar dagar merged commit 650b601 into master Jul 19, 2020
@dagar dagar deleted the pr-update_src/lib/matrix branch July 19, 2020 16:25
@MaEtUgR
Copy link
Member

MaEtUgR commented Jul 20, 2020

it's pretty minor, but letting Matrix operator() return the actual value ends up being slightly cheaper.

Then we can change it back. It didn't solve the problem I had back then. It was one of @jkflying 's good ideas on the way.

@jkflying
Copy link
Contributor

Yeah this was more around consistency of the API and avoiding surprises. If the extra dereferencing is blowing up code size we can remove it again. Or just keep it as a secret weapon for next time we run out of flash space...

@weekly-digest weekly-digest bot mentioned this pull request Jul 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilritz kamilritz Awaiting requested review from kamilritz

@MaEtUgR MaEtUgR Awaiting requested review from MaEtUgR

@dagar dagar Awaiting requested review from dagar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TSC21 @dagar @MaEtUgR @jkflying @PX4BuildBot