full commander and safety logging by default #15355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this would increase the typical nominal logging rate by somewhere around half a kilobyte per second with a corresponding (tiny) increase in cpu. |
bresch
requested changes
Jul 17, 2020
- increase battery_status rate to be useful
dagar
force-pushed
the
pr-commander_and_safety_logging
branch
from
ed31e2d to
ad90f46
Compare
|
Here we go again. |
|
Why not adding the arming/disarming reason to vehicle_status? That would make it perfectly clear what the reason was. |
I'm certainly not opposed to that. Explicit state transition reasons is something I'm hoping can be part of any state machine library/framework/etc adoption. #10584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For debugging if something goes wrong.