Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITL tests landed state fix #15335

Merged
merged 2 commits into from
Jul 15, 2020
Merged

SITL tests landed state fix #15335

merged 2 commits into from
Jul 15, 2020

Conversation

julianoes
Copy link
Contributor

@julianoes julianoes commented Jul 15, 2020

See commits for details.

@jkflying
Copy link
Contributor

If you check the commit history, it appears all the SITL tests started failing here:
fa44cd5

@julianoes
Copy link
Contributor Author

@jkflying but that change is unlikely to make the tests fail. It's just a name change.

Also, I had found the landed state bug 7 days ago in 41729ac.

With only 10 steps for e.g. 60 seconds we are likely to miss updates.
This workaround should fix the test failure where we disarm before
taking off because we accidentally switched to failsafe mode right
before taking off because we were still in Manual mode and not Hold yet.
@julianoes julianoes force-pushed the pr-sitl-tests-landed-state branch from 6f59716 to 58bdbbd Compare July 15, 2020 12:39
@julianoes julianoes requested a review from dagar July 15, 2020 12:39
@julianoes julianoes marked this pull request as ready for review July 15, 2020 12:39
@julianoes julianoes requested a review from jkflying July 15, 2020 12:39
@julianoes julianoes changed the title SITL tests debugging SITL tests landed state fix Jul 15, 2020
@dagar dagar merged commit 5f2abb6 into master Jul 15, 2020
@dagar dagar deleted the pr-sitl-tests-landed-state branch July 15, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants