Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CUAV CAN_PMU power display as 0%, unable to unlock #15314

Closed
wants to merge 1 commit into from
Closed

Fix CUAV CAN_PMU power display as 0%, unable to unlock #15314

wants to merge 1 commit into from

Conversation

CUAVcaijie
Copy link
Contributor

Since CAN PMU is not a smart battery, it cannot provide an accurate percentage of remaining power

@CUAVcaijie CUAVcaijie mentioned this pull request Jul 13, 2020
Closed
@julianoes julianoes requested a review from dagar July 14, 2020 13:24
@weekly-digest weekly-digest bot mentioned this pull request Jul 19, 2020
Closed
@CUAVcaijie
Copy link
Contributor Author

@dagar Hello, is there anything wrong with me?

@CUAVcaijie
Copy link
Contributor Author

@dagar Hello, is there any problem?

@weekly-digest weekly-digest bot mentioned this pull request Jul 26, 2020
Closed
@mrpollo
Copy link
Contributor

mrpollo commented Jul 29, 2020

@dagar please help us with feedback

@dagar
Copy link
Member

dagar commented Jul 29, 2020 •
edited
Loading

I understand the problem now, I'm just not sure about the correct fix.

  1. according to the UAVCAN spec state_of_charge_pct is required. Is there a reason it wasn't included?
    https://github.com/UAVCAN/public_regulated_data_types/blob/c043498eacfe90a56e3246d4c2e4ae81aad13082/uavcan/equipment/power/1092.BatteryInfo.uavcan#L53
    Screenshot from 2020-07-29 13-00-19

  2. Directly accessing the parameters like this is going to fall apart with more than 1 battery connected.

@CUAVcaijie
Copy link
Contributor Author

Hello, we will make changes on CAN PMU

@CUAVcaijie CUAVcaijie closed this Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagar dagar Awaiting requested review from dagar

Assignees
No one assigned
Labels
Manufacturer: cuav
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CUAVcaijie @mrpollo @dagar @jinger26