Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sed unknown option to 's' #15310

Merged
merged 1 commit into from
Jul 13, 2020
Merged

fix sed unknown option to 's' #15310

merged 1 commit into from
Jul 13, 2020

Conversation

lukegluke
Copy link
Contributor

sed: -e expression #1, char 17: unknown option to `s'
when building with windows toolchain from eclipse

when building with windows toolchain from eclipse
@lukegluke lukegluke changed the title fix sed unknown option to s' fix sed unknown option to 's' Jul 12, 2020
@dagar
Copy link
Member

dagar commented Jul 12, 2020

Thanks @lukegluke, this was annoying me on a Mac. Are we sure it doesn't break anything?

@dagar dagar requested a review from julianoes July 12, 2020 18:30
@lukegluke
Copy link
Contributor Author

Are we sure it doesn't break anything?

I don't know, I'm building custom board only on Windows.

@dagar
Copy link
Member

dagar commented Jul 12, 2020

Are we sure it doesn't break anything?

I don't know, I'm building custom board only on Windows.

Sorry, that was supposed to be directed at @julianoes in particular.

@dagar
Copy link
Member

dagar commented Jul 13, 2020

In CI there is one little complaint about STDIN, but it appears to still be working.

Screen Shot 2020-07-13 at 10 20 55 AM

@dagar dagar added the bug label Jul 13, 2020
@dagar dagar merged commit 0c376ed into PX4:master Jul 13, 2020
@lukegluke lukegluke deleted the patch-1 branch July 15, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants