Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update submodule ecl to latest Thu Feb 6 00:39:33 UTC 2020 #14107

Closed
wants to merge 1 commit into from
Closed

Update submodule ecl to latest Thu Feb 6 00:39:33 UTC 2020 #14107

wants to merge 1 commit into from

Conversation

dagar
Copy link
Member

@dagar dagar commented Feb 6, 2020 

- ecl in PX4/Firmware (a95f1c88fc011a46e8c7c130f8304ea17399103e): https://github.com/PX4/ecl/commit/ed260c4f1db8545d8ad3aa7f05d951857436ef87
- ecl current upstream: https://github.com/PX4/ecl/commit/89bcebd631024a1a91babb7b68f197dc3b6e5ca8
- Changes: https://github.com/PX4/ecl/compare/ed260c4f1db8545d8ad3aa7f05d951857436ef87...89bcebd631024a1a91babb7b68f197dc3b6e5ca8

89bcebd 2020-01-30 Paul Riseborough - EKF: Prevent covariance initialisation overwriting yaw variance
a3347b7 2020-01-30 Paul Riseborough - EKF: Use more conservative value for delta velocity bias process noise
21054a4 2020-01-30 Paul Riseborough - EKF: Fix bug causing incorrect covariance initialisation

@dagar
Copy link
Member Author

dagar commented Feb 6, 2020

@priseborough @RomanBapst any testing you'd like to see here before the ecl update with the covariance initialization fix (PX4/PX4-ECL#739) goes into PX4/Firmware master?

@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/ecl branch from c5bcd16 to 37ac44c Compare February 6, 2020 12:39
@dagar dagar requested a review from a team February 6, 2020 17:58
@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/ecl branch 5 times, most recently from 03c528c to 7a3e00d Compare February 8, 2020 12:38
@PX4 PX4 deleted a comment from codecov bot Feb 8, 2020
@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/ecl branch from 7a3e00d to dd0d3f6 Compare February 9, 2020 00:38
@codecov
Copy link

codecov bot commented Feb 9, 2020

Codecov Report

Merging #14107 into master will decrease coverage by 15.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #14107       +/-   ##
===========================================
- Coverage   51.32%   36.21%   -15.12%     
===========================================
  Files         625      552       -73     
  Lines       52988    47122     -5866     
===========================================
- Hits        27198    17065    -10133     
- Misses      25790    30057     +4267
Flag Coverage Δ
#mavsdk 36.21% <ø> (+1.04%) ⬆️
#python ?
#sitl_mission_FW ?
#sitl_mission_MC_box ?
#sitl_mission_MC_offboard_att ?
#sitl_mission_MC_offboard_pos ?
#sitl_mission_Rover ?
#sitl_mission_VTOL_standard ?
#sitl_mission_VTOL_tailsitter ?
#sitl_python_FW ?
#sitl_python_MC_box ?
#sitl_python_MC_offboard_att ?
#sitl_python_MC_offboard_pos ?
#sitl_python_Rover ?
#sitl_python_VTOL_standard ?
#sitl_python_VTOL_tailsitter ?
#unittest ?
Impacted Files Coverage Δ
...b/flight_tasks/tasks/Descend/FlightTaskDescend.cpp 0% <0%> (-83.34%) ⬇️
platforms/posix/src/px4/common/lib_crc32.c 0% <0%> (-66.67%) ⬇️
src/modules/mavlink/mavlink_timesync.cpp 75% <0%> (-12.5%) ⬇️
src/modules/mavlink/mavlink_parameters.cpp 31.57% <0%> (-12.96%) ⬇️
src/modules/mavlink/mavlink_mission.cpp 32.28% <0%> (-7.82%) ⬇️
...flight_tasks/tasks/Failsafe/FlightTaskFailsafe.cpp 69.56% <0%> (-4.35%) ⬇️
src/modules/navigator/mission.cpp 44.98% <0%> (-6.17%) ⬇️
.../modules/navigator/mission_feasibility_checker.cpp 34.49% <0%> (-9.5%) ⬇️
src/lib/parameters/parameters.cpp 64.8% <0%> (-6.5%) ⬇️
src/modules/vtol_att_control/vtol_type.cpp 61.57% <0%> (-1.48%) ⬇️
... and 90 more

@weekly-digest weekly-digest bot mentioned this pull request Feb 9, 2020
Closed
@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/ecl branch 5 times, most recently from 0c1ad0a to 9a04726 Compare February 11, 2020 12:38
@jorge789
Copy link

Tested on PixRacer V4

Indoor Flight Test
Modes Tested
Stabilized Mode: Good.

Procedure
Arm and Take off in stabilized mode.

Notes
No issues noted, good flight in general.

Log https://review.px4.io/plot_app?log=11153d21-ec17-4dfc-8bb6-c161131f06a1

Tested on CUAV nano V5

Indoor Flight Test
Modes Tested
Stabilized Mode: Good.

Procedure
Arm and Take off in stabilized mode.

Notes
No issues noted, good flight in general.

Log https://review.px4.io/plot_app?log=9fd00bfb-68e0-4e9a-a7ad-6f519f0b9707

@dannyfpv
Copy link

Tested on pixhawk4 v5 f-450
Indoor Flight Test
Modes Tested
Stabilized Mode: Good.

Procedure
Arm and Take off in stabilized mode.

Notes
No issues noted, good flight in general.

Log
https://review.px4.io/plot_app?log=f06345f6-8b34-4882-9fcd-74388ad8648d

@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/ecl branch from 9a04726 to dc013aa Compare February 12, 2020 00:39
@PX4BuildBot
Update submodule ecl to latest Wed Feb 12 12:39:35 UTC 2020
62b7ed2 
    - ecl in PX4/Firmware (43d87d2): PX4/PX4-ECL@ed260c4
    - ecl current upstream: PX4/PX4-ECL@89bcebd
    - Changes: PX4/PX4-ECL@ed260c4...89bcebd

    89bcebd 2020-01-30 Paul Riseborough - EKF: Prevent covariance initialisation overwriting yaw variance
a3347b7 2020-01-30 Paul Riseborough - EKF: Use more conservative value for delta velocity bias process noise
21054a4 2020-01-30 Paul Riseborough - EKF: Fix bug causing incorrect covariance initialisation
@PX4BuildBot PX4BuildBot force-pushed the pr-update_src/lib/ecl branch from dc013aa to 62b7ed2 Compare February 12, 2020 12:39
@dagar
Copy link
Member Author

dagar commented Feb 12, 2020

Closing in favor of #14147.

@dagar dagar closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug EKF2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dagar @jorge789 @dannyfpv @PX4BuildBot