-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTOL: disable WV when moving #13782
VTOL: disable WV when moving #13782
Conversation
ab226f9
to
7d295fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfuhrer If this works better for VTOL then I'm fine with bringing it in.
… if position isn't locked Signed-off-by: Silvan Fuhrer <[email protected]>
Use yawrate setpoint from weather vane only if velocity setpoint is small (smaller than half the cruise velocity) Signed-off-by: Silvan Fuhrer <[email protected]>
7d295fd
to
f5a7d7b
Compare
Found an issue with the previous implementation, fixed it and flight tested it again now. No conceptual changes, so I assume you're still okay with that @RomanBapst ? |
Codecov Report
@@ Coverage Diff @@
## master #13782 +/- ##
==========================================
- Coverage 36.44% 36.02% -0.42%
==========================================
Files 587 548 -39
Lines 49337 47003 -2334
==========================================
- Hits 17982 16935 -1047
+ Misses 31355 30068 -1287
|
This PR disables weather vane (WV) when moving. Background is that when moving lateral, the roll offset required for this motion also introduces a yawing rate from the WV. This is normally not desired for VTOL when flying in windy conditions, as then the nose of the vehicle gets turned out of the wind, leading to crosswind or tailwind situations.
After this PR, the weather vane would still be active when:
In low-wind conditions it it could maybe be desired to have the WV always active in auto mode (like it is now), such that the vehicle automatically yaws in direction of flight. We could thus add a parameter to enable WV in auto mode also when moving. Or instead of making the threshold for WV on/off depending on MC_XY_CRUISE like it is now, making a threshold parameter (which, when set to a high velocity, would always enable WV).
I'm currently rather for the option without another parameter if it can be avoided.