Config: add tests for setting --extensions
#872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/config-add-tests-for-extensions
branch
from
f977cf5 to
d035cd0
Compare
Includes minor bug fix to treat an empty value correctly.
Previously, passing `--extensions=` (without value) would result in the `Config::$extensions` property being set to:
```php
public $extensions = [
'' => 'PHP'
];
```
Now, an empty value will set the extensions array to an empty array.
```php
public $extensions = [];
```
Note: in practice, the above change will not make a difference in how files are filtered/scanned.
:point_right: The change to the `Config` class will be most straight-forward to review while ignoring whitespace changes.
jrfnl
force-pushed
the
feature/config-add-tests-for-extensions
branch
from
d035cd0 to
25d0f75
Compare
Slash handling is going away in 4.0 with the drop of the JS/CSS tokenizer, so as of 4.0, slashes in the values will throw an error (which is also why I added the tests as it will allow for having that change covered via the tests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes minor bug fix to treat an empty value correctly.
Previously, passing
--extensions=(without value) would result in theConfig::$extensionsproperty being set to:Now, an empty value will set the extensions array to an empty array.
Note: in practice, the above change will not make a difference in how files are filtered/scanned.
👉 The change to the
Configclass will be most straight-forward to review while ignoring whitespace changes.Suggested changelog entry
N/A