Fix script dependency on content types UI #17570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
reviewed
Mar 6, 2025
| @@ -51,7 +51,7 @@ | |||
| </div> | |||
| </form> | |||
|
|
|||
| <script at="Foot"> | |||
| <script at="Foot" depends-on="admin"> | |||
There was a problem hiding this comment.
I think because theadmin.js was added global on mast pages. Or it could be due to the recent change in the resource. maybe @Skrypt moved the getTechnicalName function.
There was a problem hiding this comment.
I'm wonder if there many places affected!!
/cc @Skrypt
|
This did not fix the issue. @Skrypt I am wondering if you had made changes to assets so that |
agriffard
changed the title
|
These methods needs to be moved to the Global methods. Will fix. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17565