Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DDS Textures #6

Closed
aussig opened this issue Jul 13, 2019 · 4 comments
Closed

Support DDS Textures #6

aussig opened this issue Jul 13, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@aussig
Copy link

aussig commented Jul 13, 2019

The X-Plane format supports DDS textures. Note that X-Plane will try to load DDS textures if available irrespective whether the TEXTURE path points to a .png, so we should probably do the same.

@aussig aussig added the enhancement New feature or request label Jul 13, 2019
@aussig aussig self-assigned this Jul 13, 2019
@aussig
Copy link
Author

aussig commented Jul 30, 2019

Although this is implemented, we can't use it yet because of this bug: mrdoob#4316 where compressed DDS textures are displayed upside-down.

@aussig
Copy link
Author

aussig commented Jul 31, 2019

One solution is we switch off texture flipping completely (it is on by default), which would apply to all textures including PNGs. We would then reverse our vertical texture coordinates in all cases.

aussig added a commit that referenced this issue Apr 9, 2020
…in UV coordinates to work around mrdoob#4316, allowing us to use uncompressed DDS, compressed DDS and PNG textures interchangeably. Closes #6.
@aussig aussig closed this as completed Apr 9, 2020
@aussig
Copy link
Author

aussig commented Apr 11, 2020

Polygon textures need to be flipped too, because letters such as https://www.opensceneryx.com/polygons/airport/taxisign_parts/characters_yellow/p/ are appearing upside-down. Might be worth doing the same with lines as well, in case they ever include letters.

@aussig aussig reopened this Apr 11, 2020
aussig added a commit that referenced this issue Apr 11, 2020
… flip uvs for vertical texture coordinates. #6.
@aussig
Copy link
Author

aussig commented Apr 11, 2020

Polygons are now fixed. Lines didn't need any changes.

@aussig aussig closed this as completed Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant