Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tensor topk param #9703

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Fix tensor topk param #9703

merged 4 commits into from
Jan 6, 2023

Conversation

marigoold
Copy link
Contributor

@marigoold marigoold commented Jan 5, 2023 •
edited
Loading

close #9695

@marigoold marigoold mentioned this pull request Jan 5, 2023
Closed
@marigoold marigoold enabled auto-merge (squash) January 5, 2023 14:55
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@marigoold marigoold requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 5, 2023 15:00
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Speed stats: 
GPU Name: GeForce GTX 1080 









❌ OneFlow resnet50 time: 139.9ms (= 13995.0ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 163.6ms (= 16360.8ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.17 (= 163.6ms / 139.9ms)

OneFlow resnet50 time: 85.3ms (= 8532.6ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 102.7ms (= 10274.7ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.20 (= 102.7ms / 85.3ms)

OneFlow resnet50 time: 57.8ms (= 11569.0ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 78.3ms (= 15651.9ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.35 (= 78.3ms / 57.8ms)

OneFlow resnet50 time: 46.2ms (= 9240.4ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 76.5ms (= 15299.6ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.66 (= 76.5ms / 46.2ms)

OneFlow resnet50 time: 40.9ms (= 8180.9ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 68.7ms (= 13730.9ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.68 (= 68.7ms / 40.9ms)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/9703/

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

CI failed when running job: cpu-module. PR label automerge has been removed

@github-actions github-actions bot removed the automerge label Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Speed stats: 
GPU Name: GeForce GTX 1080 









❌ OneFlow resnet50 time: 139.9ms (= 13985.6ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 168.4ms (= 16842.0ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.20 (= 168.4ms / 139.9ms)

OneFlow resnet50 time: 85.5ms (= 8548.6ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 103.7ms (= 10372.3ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.21 (= 103.7ms / 85.5ms)

OneFlow resnet50 time: 57.8ms (= 11559.1ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 78.8ms (= 15757.3ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.36 (= 78.8ms / 57.8ms)

OneFlow resnet50 time: 44.1ms (= 8810.7ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 82.2ms (= 16436.1ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.87 (= 82.2ms / 44.1ms)

OneFlow resnet50 time: 42.0ms (= 8403.9ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 76.3ms (= 15262.3ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.82 (= 76.3ms / 42.0ms)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/9703/

@marigoold marigoold merged commit c376b8f into master Jan 6, 2023
@marigoold marigoold deleted the fix_tensor_topk_param branch January 6, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daquexian daquexian daquexian approved these changes

@BBuf BBuf BBuf approved these changes

@youxiudeshouyeren youxiudeshouyeren youxiudeshouyeren approved these changes

@hjchen2 hjchen2 Awaiting requested review from hjchen2 hjchen2 is a code owner

@jackalcooper jackalcooper Awaiting requested review from jackalcooper

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
api automerge enhancement test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

topk op issue
5 participants
@marigoold @daquexian @BBuf @youxiudeshouyeren @oneflow-ci-bot