Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed min/max page width #4

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Sorunome
Copy link
Member

all tested

Sorunome added 5 commits June 29, 2015 21:29
we actually want the wrapper size, not the window size
@Eeems
Copy link
Member

Eeems commented Jun 30, 2015

Have you tested this on all major pages at various screen sizes?

@Sorunome
Copy link
Member Author

Haven't gotten to big screen sizes, yet

@Eeems
Copy link
Member

Eeems commented Jun 30, 2015

Let me know when you do

@Eeems
Copy link
Member

Eeems commented Jul 10, 2015

Looks like #wrapper needs some adjusting. sizing the window too small causes issues.

@Sorunome
Copy link
Member Author

yeah the adjustments for the lower bound are already adjusted, just the one for the upper haven't been tested yet.

@@ -95,14 +95,14 @@ $(function(){
var $sheet = $('<style>').appendTo('head');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting an illegal string was specified error when trying to run this section of code manually (Not this specific line)

@Sorunome
Copy link
Member Author

done with the testing, added back a max-width else very long lines get tiresome to read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants