-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed min/max page width #4
base: master
Are you sure you want to change the base?
Conversation
all tested
we actually want the wrapper size, not the window size
Have you tested this on all major pages at various screen sizes? |
Haven't gotten to big screen sizes, yet |
Let me know when you do |
Looks like #wrapper needs some adjusting. sizing the window too small causes issues. |
yeah the adjustments for the lower bound are already adjusted, just the one for the upper haven't been tested yet. |
@@ -95,14 +95,14 @@ $(function(){ | |||
var $sheet = $('<style>').appendTo('head'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting an illegal string was specified error when trying to run this section of code manually (Not this specific line)
done with the testing, added back a max-width else very long lines get tiresome to read |
all tested