Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(env-checker): fix missing env checker popup when run f5 from WSL #1085

Merged
merged 6 commits into from
May 18, 2021
Merged

feat(env-checker): fix missing env checker popup when run f5 from WSL #1085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
562609b
feat: fix missing env checker popup when run f5 from WSL
meifans May 18, 2021
edbf295
Merge branch 'release/20210514' of github.com:OfficeDev/TeamsFx into …
meifans May 18, 2021
56ce1ea
fix: remove opn in vscode-extension
meifans May 18, 2021
5863930
fix: use await
meifans May 18, 2021
1d6c2aa
fix: update package-lock.json
meifans May 18, 2021
975d844
chore: regen lock files
LongOddCode May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,242 changes: 304 additions & 938 deletions packages/api/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

425 changes: 37 additions & 388 deletions packages/cli/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

838 changes: 419 additions & 419 deletions packages/eslint-config/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

759 changes: 332 additions & 427 deletions packages/fx-core/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion packages/fx-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
"node-forge": "^0.10.0",
"node-ts-uuid": "^1.0.8",
"openapi-types": "^7.2.3",
"opn": "^6.0.0",
"semver": "^7.3.4",
"sudo-prompt": "^9.2.1",
"tedious": "^9.2.1",
Expand Down
9 changes: 0 additions & 9 deletions packages/fx-core/src/plugins/resource/function/utils/depsChecker/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,6 @@
// to copy you changes to function plugin.

import * as os from "os";
const opn = require("opn");

export async function openUrl(url: string): Promise<void> {
// Using this functionality is blocked by https://github.com/Microsoft/vscode/issues/25852
// Specifically, opening the Live Metrics Stream for Linux Function Apps doesn't work in this extension.
// await vscode.env.openExternal(vscode.Uri.parse(url));

opn(url);
}

export function isWindows(): boolean {
return os.type() === "Windows_NT";
Expand Down
Loading