Added chainlink oracle price as price source on BASE #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o old price tickers on others)
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
piotrkonowrocki
previously approved these changes
Nov 10, 2023
piotrkonowrocki
approved these changes
Nov 10, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
piotrkonowrocki
deleted the
marcinciarka/chainlink-oracle-for-cbeth-eth-on-base
branch
jakubswierczek
added a commit
that referenced
this pull request
Nov 13, 2023
This reverts commit ca45b8d.
jakubswierczek
added a commit
that referenced
this pull request
Nov 13, 2023
jakubswierczek
added a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chainlink oracle price as price source on BASE
Changes 👷♀️
oracleTickeringetPriceso it's gonna get picked first (if defined)getSDaiOracleTickerHow to test 🧪