Spp 6805 h value to boolean #86
Merged
+491
−553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingmushroom
previously approved these changes
Jun 27, 2022
arthompson
reviewed
Jun 27, 2022
There was a problem hiding this comment.
The idea is that the input column is already boolean and that we would convert that into an integer in the method. What this does is take a numeric column, convert it to boolean and then convert it back. As such, the initial when prior to the alias needs to be removed as the h value column will already be boolean.
DanWhite3
approved these changes
Jun 28, 2022
kingmushroom
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.