Add mc unittest data for RoM #187
Merged
+117
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidhyamanisankar
changed the title
…so prevent redutant joins
BenLatham
approved these changes
Jun 3, 2024
kingmushroom
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
Briefly describe the purpose of the pr.
Added unittest data given by methodologist to test the manual construction with Ration of mean(RoM) imputation.
refactored the mc data filter-out logic just before imputation stage So MC data was included in the ratio and weight calculations; nevertheless, this will have no effect on links because it is still a non-responder.
Checklist
Description
Add a more detailed description of the pr if necessary (can reference release
notes if included).