Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to using macOS 12 for VR tests #3157

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Apr 25, 2024

What is the context of this PR?

Fixes: #3159

Github seems to have recently updated their macos-latest runner to use macOS 14 (as explained here April 24 - https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/). These runners use the new Apple silicon CPUs which are currently incompatible with running colima (abiosoft/colima#970) which is what we use to run our VR tests.

This PR specifies that we use macOS 12 rather than "Latest".

How to review this PR

  • Check the VR tests on another PR see the colima error
  • See that the VR tests run and pass on this PR

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar added the Dependencies Pull requests that update a dependency file label Apr 25, 2024
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit e54975f
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/662a599d8fb7e300081922dd
😎 Deploy Preview https://deploy-preview-3157--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar requested a review from a team April 25, 2024 13:31
@rmccar rmccar self-assigned this Apr 25, 2024
@rmccar rmccar merged commit 93b8bc4 into main Apr 26, 2024
14 of 16 checks passed
@rmccar rmccar deleted the revert-to-using-macos-12-for-vr-tests branch April 26, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VR tests failing with colima command error on Github actions
3 participants