[18.0][MIG] website_sale_vat_required: Migration to version 18.0 #1029
Conversation
|
/ocabot migration website_sale_vat_required |
|
This PR has the |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1029-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@carlos-lopez-tecnativa please rebase and check the problem. |
[FIX] Depend on vat validation module that causes the VAT number field to be displayed at checkout in the first place
This addon got migrated from 8.0. Relevant notes: - Moved from `OCA/website` to `OCA/e-commerce`. - Reduced license headers to new style ones, keeping copyright. - Updated README template. - Replaced dirty hack that disables addon in test mode, and hack the tour instead (actually testing the addon). - Benefit from upstream updates, that now handles incorrect VAT errors.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-12.0/e-commerce-12.0-website_sale_vat_required Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_vat_required/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-13.0/e-commerce-13.0-website_sale_vat_required Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_vat_required/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-15.0/e-commerce-15.0-website_sale_vat_required Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_vat_required/
…hods in test Modify the tests so that we don't have to rely on the payment methods module to run the tests for the functionality of this module. TT44388
The tests were using a demo data product so if at any time this product does not exist the tests start to fail. To avoid this, a new product is created and used for testing. Also to locate the checkout button it is better to locate it by its container element as the classes can change depending on the configuration and modules used in the instance and it can be a problem to locate it.
Adapt according to this commit: odoo/odoo@453cfab
carlos-lopez-tecnativa
force-pushed
the
18.0-mig-website_sale_vat_required
branch
from
1028899 to
2c745a5
Compare
I adapted the code in the tour. The issue was caused because this module hides the element e-commerce/website_sale_checkout_country_vat/views/templates.xml Lines 8 to 14 in d8a3e37 name attribute instead.
Could you please retry? Thanks. |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at bae8a6c. Thanks a lot for contributing to OCA. ❤️ |
Adapt according to this commit: odoo/odoo@453cfab
TT54540
@Tecnativa @pedrobaeza @CarlosRoca13 @pilarvargas-tecnativa could you please review this?