feat(modifier-managers): use 3.22 capabilities

BREAKING CHANGE: destruction behavior changed to use new args proxy from 3.22 Resolves the issue described by: emberjs/ember.js#19162 fixed by: emberjs/ember.js#19163
NullVoxPopuli · Oct 16, 2020 · 3c0ccc9 · 3c0ccc9
1 parent a2cfad4
commit 3c0ccc9
Show file tree

Hide file tree

Showing 8 changed files with 1,540 additions and 103 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -49,9 +49,7 @@ jobs:
     # we recommend new addons test the current and previous LTS
     # as well as latest stable release (bonus points to beta/canary)
     - stage: "Additional Tests"
-      env: EMBER_TRY_SCENARIO=ember-lts-2.18
-    - env: EMBER_TRY_SCENARIO=ember-lts-3.4
-    - env: EMBER_TRY_SCENARIO=ember-release
+      env: EMBER_TRY_SCENARIO=ember-release
     - env: EMBER_TRY_SCENARIO=ember-beta
     - env: EMBER_TRY_SCENARIO=ember-canary
     - env: EMBER_TRY_SCENARIO=ember-default-with-jquery

diff --git a/addon/modifiers/did-insert.js b/addon/modifiers/did-insert.js
@@ -46,7 +46,7 @@ import { setModifierManager, capabilities } from '@ember/modifier';
 */
 export default setModifierManager(
   () => ({
-    capabilities: capabilities('3.13', { disableAutoTracking: true }),
+    capabilities: capabilities('3.22'),
 
     createModifier() {},
 

diff --git a/addon/modifiers/did-update.js b/addon/modifiers/did-update.js
@@ -58,7 +58,7 @@ import { setModifierManager, capabilities } from '@ember/modifier';
 */
 export default setModifierManager(
   () => ({
-    capabilities: capabilities('3.13', { disableAutoTracking: true }),
+    capabilities: capabilities('3.22'),
 
     createModifier() {
       return { element: null };

diff --git a/addon/modifiers/will-destroy.js b/addon/modifiers/will-destroy.js
@@ -40,7 +40,7 @@ import { setModifierManager, capabilities } from '@ember/modifier';
 */
 export default setModifierManager(
   () => ({
-    capabilities: capabilities('3.13', { disableAutoTracking: true }),
+    capabilities: capabilities('3.22'),
 
     createModifier() {
       return { element: null };

diff --git a/config/ember-try.js b/config/ember-try.js
@@ -11,26 +11,6 @@ module.exports = function() {
     return {
       useYarn: true,
       scenarios: [
-        {
-          name: 'ember-lts-2.18',
-          env: {
-            EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true }),
-          },
-          npm: {
-            devDependencies: {
-              '@ember/jquery': '^0.5.1',
-              'ember-source': '~2.18.0',
-            },
-          },
-        },
-        {
-          name: 'ember-lts-3.4',
-          npm: {
-            devDependencies: {
-              'ember-source': '~3.4.0',
-            },
-          },
-        },
         {
           name: 'ember-release',
           npm: {

diff --git a/package.json b/package.json
@@ -22,8 +22,7 @@
     "test:all": "ember try:each"
   },
   "dependencies": {
-    "ember-cli-babel": "^7.10.0",
-    "ember-modifier-manager-polyfill": "^1.1.0"
+    "ember-cli-babel": "^7.10.0"
   },
   "devDependencies": {
     "@ember/optional-features": "^0.7.0",
@@ -37,7 +36,7 @@
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-qunit": "^4.2.0",
     "ember-resolver": "^5.0.1",
-    "ember-source": "~3.7.0",
+    "ember-source": "~3.22.0",
     "ember-source-channel-url": "^1.1.0",
     "ember-template-lint": "^1.1.0",
     "ember-try": "^1.0.0",

diff --git a/tests/integration/modifiers/did-update-test.js b/tests/integration/modifiers/did-update-test.js
@@ -1,6 +1,6 @@
 import { module, test } from 'qunit';
 import { setupRenderingTest } from 'ember-qunit';
-import { render } from '@ember/test-helpers';
+import { render, settled } from '@ember/test-helpers';
 import hbs from 'htmlbars-inline-precompile';
 
 module('Integration | Modifier | did-update', function(hooks) {
@@ -23,5 +23,6 @@ module('Integration | Modifier | did-update', function(hooks) {
     );
 
     this.set('boundValue', 'update');
+    await settled();
   });
 });