Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from Microsoft.Azure.KeyVault to Azure.Security.KeyVault #9654

Merged
merged 12 commits into from
Sep 11, 2023

Conversation

erdembayar
Copy link
Contributor

@erdembayar erdembayar commented Sep 8, 2023

Related to: https://github.com/NuGet/Engineering/issues/4704

Transition from Microsoft.Azure.KeyVault to Azure.Security.KeyVault package dependency. Former one is deprecated.
I manually tested this change in Gallery dev environment

@erdembayar erdembayar marked this pull request as ready for review September 8, 2023 17:40
@erdembayar erdembayar requested a review from a team as a code owner September 8, 2023 17:40
joelverhagen
joelverhagen previously approved these changes Sep 8, 2023
Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: - I'll need to re-approve after changes though.

Copy link
Contributor Author

@erdembayar erdembayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed inline comments in code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants