Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework Generation constants for Search-by-TFM #9270

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

advay26
Copy link
Member

@advay26 advay26 commented Oct 4, 2022

This is part of the work in NuGet/NuGet.Jobs#1096.

We will need to use these constants to represent Framework Generations in the search index, and in the URL query parameters, so they will be used by both NuGet.Jobs and NuGetGallery.

These Framework Generation strings are based on the shortname framework identifiers. There isn't currently a shortname identifier for .NET Framework (< 5.0), so we created our own constants, which includes "netframework" for .NET Framework.

@advay26 advay26 requested a review from a team as a code owner October 4, 2022 20:25
@advay26 advay26 merged commit 5e27c1e into dev Oct 4, 2022
@advay26 advay26 deleted the advay26-sbtfm-constants branch October 4, 2022 20:48
@advay26 advay26 mentioned this pull request Oct 4, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants