Change httpPost to httpGet #8269
Conversation
lyndaidaii
requested review from
agr,
cristinamanum,
dannyjdev,
drewgillies,
joelverhagen,
loic-sharma,
ryuyu,
shishirx34,
skofman1,
xavierdecoster and
zhhyu
as code owners
| @@ -227,9 +227,8 @@ public virtual JsonResult UploadPackageProgress() | |||
| return Json(progress, JsonRequestBehavior.AllowGet); | |||
| } | |||
|
|
|||
| [HttpPost] | |||
| [HttpGet] | |||
There was a problem hiding this comment.
Why change this one to HttpGet? Doesn't it change DB state and hence should be a POST?
There was a problem hiding this comment.
This is a read-only endpoint. It checks for an already uploaded package (uploads container, not yet submitted) and returns the metadata view model. Otherwise, it returns an empty view model.
There was a problem hiding this comment.
The overloads are very confusing here TBH, but if you open it in VS and step through the code, this is the read-only endpoint that is the first step of the UI upload process. A subsequent "verify" endpoint is the POST and does the DB state changes.
|
If it's related to the failure of functional tests, should we understand what changes make it failed recently but succeed before, rather than suppress it? What if something is happening but functional tests don't have the coverage on it? |
|
Deployed to dev, E2E tests pass |
No description provided.