Fix unit test failed due to localized culture and line ending (#7779) #8021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyndaidaii
requested review from
agr,
cristinamanum,
dannyjdev,
joelverhagen,
loic-sharma,
ryuyu,
shishirx34,
skofman1,
xavierdecoster and
zhhyu
as code owners
| var packageStream = CreateTestPackageStreamWithDuplicateEmptyAndNonEmptyMetadataElements(); | ||
| var nupkg = new PackageArchiveReader(packageStream, leaveStreamOpen: false); | ||
| var nuspec = nupkg.GetNuspecReader(); | ||
|
|
||
| useInvariantCultureAttr.Before(null); |
There was a problem hiding this comment.
Can use the attribute on the test method like here: https://hamidmosalla.com/2018/08/30/xunit-beforeaftertestattribute-how-to-run-code-before-and-after-test/ ?
There was a problem hiding this comment.
We definitely shouldn't instantiate the attribute class directly. It already contains all necessary setup, just use [UseInvariantCulture] attribute on appropriate test methods.
agr
reviewed
Jun 2, 2020
| @@ -215,7 +218,7 @@ public void ThrowsWhenInvalidMinClientVersion(bool strict) | |||
|
|
|||
| // Act & Assert | |||
| var ex = Assert.Throws<ArgumentException>(() => PackageMetadata.FromNuspecReader(nuspec, strict)); | |||
| Assert.Equal("'bad' is not a valid version string.\r\nParameter name: value", ex.Message); | |||
| Assert.StartsWith("'bad' is not a valid version string.", ex.Message); | |||
There was a problem hiding this comment.
We need an additional explicit check for parameter name (that was implicit in old version): Assert.Equal("value", ex.ParamName) here and in other cases.
agr
requested changes
Jun 2, 2020
| { | ||
| private CultureInfo originalUICulture; | ||
|
|
||
| public CultureInfo OriginalUICulture { get; set; } |
There was a problem hiding this comment.
I am not sure if this is used anywhere, If not can it be removed?
cristinamanum
approved these changes
Jun 3, 2020
agr
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes:
after test
3.NuGetGallery.PackagesControllerFacts+TheUploadFileActionForPostRequests.WillRejectBrokenZipFiles NuGetGallery.PackagesControllerFacts+TheUploadFileActionForPostRequests.WillShowViewWithErrorsIfPackageIdIsBreaksParsing
4.NuGetGallery.Authentication.AuthenticationServiceFacts+TheAuthenticateMethod.GivenPasswordCredential_ItThrowsArgumentException
5.NuGetGallery.Diagnostics.DiagnosticsServiceFacts+TheGetSourceMethod.RequiresNonNullOrEmptyName
6.NuGetGallery.Services.ContentServiceFacts+TheGetContentItemMethod.GivenANullOrEmptyName_ItShouldThrow
Addresses #123