Add Symbols Feature flag #6207
Add Symbols Feature flag #6207
Conversation
shishirx34
requested review from
joelverhagen,
agr,
loic-sharma,
ryuyu,
anangaur,
chenriksson,
cristinamanum,
skofman1,
scottbommarito and
zhhyu
| @@ -10,7 +10,7 @@ namespace NuGetGallery | |||
| { | |||
| public class ContentObjectService : IContentObjectService | |||
| { | |||
| private const int RefreshIntervalHours = 1; | |||
| private const int RefreshIntervalMinutes = 5; | |||
|
|
|||
There was a problem hiding this comment.
Why changing this ? What it would be the impact?
There was a problem hiding this comment.
These content configuration objects will refresh more often.
If we change configuration, it will take less time for us to see it change.
We've determined that 1 hour has been too long, and we would like to increase the frequency to every 5 minutes.
There was a problem hiding this comment.
An hour was way too long for any config change to take effect. We've been wanting to reduce this for a while. I consulted with @scottbommarito and decided 5 mins seems appropriate. There shouldn't be any perf impact by this change.
|
|
||
| namespace NuGetGallery.Services | ||
| { | ||
| public sealed class SymbolsConfiguration : ISymbolsConfiguration |
There was a problem hiding this comment.
This is basically a clone of CertificatesConfiguration, right?
IMO we should write a base class that both can use so we don't have to keep rewriting this.
Bonus points if the base class is resusable by ILoginDiscontinuationConfiguration as well.
I don't think it would take very long.
There was a problem hiding this comment.
Yeah I agree, however, we are going to get rid of CertificatesConfiguration and I would rather not spend time on not strictly required refactoring right now. I have opened an issue to track this.
Addresses #6169
Also, I have reduced the reload duration to 5 minutes for configuration, it was 1 hour. This feature flag will be used in subsequent PRs to allow/prevent symbols upload until we go live with this feature.