Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API keys page failure if user has API keys for orgs they are no longer a member of #5871

Merged
merged 2 commits into from
May 2, 2018
Merged

Fix API keys page failure if user has API keys for orgs they are no longer a member of #5871

merged 2 commits into from
May 2, 2018

Conversation

scottbommarito
Copy link
Contributor

skofman1
skofman1 approved these changes May 2, 2018
View reviewed changes
Copy link
Contributor

@skofman1 skofman1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as a hotfix, but please open an issue to fix the behavior: we need to disable all editting of the api key and allow only delete

@scottbommarito
Copy link
Contributor Author

@skofman1 filed #5872

@scottbommarito scottbommarito merged commit e01b75e into dev May 2, 2018
@scottbommarito scottbommarito deleted the sb-apikeyswithmissingowner branch May 2, 2018 19:29
@scottbommarito scottbommarito restored the sb-apikeyswithmissingowner branch July 22, 2019 23:19
@scottbommarito scottbommarito deleted the sb-apikeyswithmissingowner branch July 22, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenriksson chenriksson chenriksson approved these changes

@skofman1 skofman1 skofman1 approved these changes

@joelverhagen joelverhagen Awaiting requested review from joelverhagen

@agr agr Awaiting requested review from agr

@loic-sharma loic-sharma Awaiting requested review from loic-sharma

@xavierdecoster xavierdecoster Awaiting requested review from xavierdecoster

@shishirx34 shishirx34 Awaiting requested review from shishirx34

@nugetlurker nugetlurker Awaiting requested review from nugetlurker

@ryuyu ryuyu Awaiting requested review from ryuyu

@rido-min rido-min Awaiting requested review from rido-min

@cristinamanum cristinamanum Awaiting requested review from cristinamanum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottbommarito @chenriksson @skofman1