Remove usernames and emails from AI traces. #5293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinamanum
requested review from
chenriksson,
shishirx34,
agr,
joelverhagen,
ryuyu,
scottbommarito,
skofman1 and
loic-sharma
loic-sharma
reviewed
Jan 19, 2018
| @@ -756,7 +755,7 @@ private User FindByUserNameOrEmail(string userNameOrEmail) | |||
| else | |||
| { | |||
| // If multiple matches, leave it null to signal no unique email address | |||
| _trace.Warning("Multiple user accounts with email address: " + userNameOrEmail + " found: " + String.Join(", ", allMatches.Select(u => u.Username))); | |||
| _trace.Warning("Multiple user accounts with a single email address were found. Count: " + String.Join(", ", allMatches.Select(u => u.Username))); | |||
There was a problem hiding this comment.
I'm guessing String.Join(", ", allMatches.Select(u => u.Username)) should be allMatches.Count()?
There was a problem hiding this comment.
Right, good catch. Fixed.
There was a problem hiding this comment.
@chenriksson - First comment - thank you - fixed.
Second comment - plain Client IP is not ok - needs to be obfuscated.
There was a problem hiding this comment.
Verified the traces for cookie compliance and do not seem to be IPs in the messages.
loic-sharma
approved these changes
Jan 19, 2018
|
SecurePushSubscription may have Client IP is ok in AI logs, right? |
chenriksson
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usernames and emails from AI traces.