Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReleasePrep][2017.10.30]RI of dev into master #4928

Merged
merged 17 commits into from
Oct 31, 2017
Merged

[ReleasePrep][2017.10.30]RI of dev into master #4928

merged 17 commits into from
Oct 31, 2017

Conversation

loic-sharma
Copy link
Contributor

chenriksson and others added 16 commits October 23, 2017 11:59
* Remove "pending edit" notifications from package details view

* Remove min-client requirement for push message on package details view

* Mark AuditedPackageAction.UndoEdit as obsolete
…4918)

* Pakage URL generation method and checks whether package file exists for the NuGetGallery.Core (Validation.Orchestrator needs those)

* GetPackageUrlAsync -> GetPackageReadUriAsync

* Minor test fixes
[ReleasePrep][2017.10.30]FI of master into dev
Copy link
Contributor

@agr agr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My changes look good.

Copy link
Contributor

@scottbommarito scottbommarito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a dumb issue in the permissions stuff, sending out quick fix now

Copy link
Member

@xavierdecoster xavierdecoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My changes look good.

Copy link
Contributor

@scottbommarito scottbommarito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fixed now

Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loic-sharma loic-sharma merged commit 46258fb into master Oct 31, 2017
@loic-sharma loic-sharma mentioned this pull request Nov 2, 2017
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing info for prerelease package
10 participants