Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building signed&unsigned nugetgallery.core packages #4919

Merged
merged 5 commits into from
Oct 27, 2017
Merged

Add support for building signed&unsigned nugetgallery.core packages #4919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8888dd
Build signed and unsigned NuGetGallery.Core
Oct 26, 2017
0e0b8b7
try
Oct 26, 2017
3cd58f6
try2
Oct 26, 2017
9ec7362
try3
Oct 26, 2017
0372e24
cleanup
Oct 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ param (
[switch]$CleanCache,
[string]$SimpleVersion = '1.0.0',
[string]$SemanticVersion = '1.0.0-zlocal',
[string]$PackageSuffix,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this default to ''? Does this work locally without parameters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works without providing a parameter

[string]$Branch,
[string]$CommitSHA,
[string]$BuildBranch = '37ff6e758c38b3f513af39f881399ce85f4ff20b'
Expand Down Expand Up @@ -84,12 +85,13 @@ Invoke-BuildStep 'Building solution' {
Build-Solution $Configuration $BuildNumber -MSBuildVersion "15" $SolutionPath -SkipRestore:$SkipRestore -MSBuildProperties "/p:MvcBuildViews=true" `
} `
-ev +BuildErrors

Invoke-BuildStep 'Creating artifacts' {
New-Package (Join-Path $PSScriptRoot "src\NuGetGallery.Core\NuGetGallery.Core.csproj") -Configuration $Configuration -Symbols -BuildNumber $BuildNumber -Version $SemanticVersion `
-ev +BuildErrors
}

Invoke-BuildStep 'Creating artifacts' {
$packageId = 'NuGetGallery.Core'+$PackageSuffix
New-Package (Join-Path $PSScriptRoot "src\NuGetGallery.Core\NuGetGallery.Core.csproj") -Configuration $Configuration -Symbols -BuildNumber $BuildNumber -Version $SemanticVersion -PackageId $packageId `
-ev +BuildErrors
}

Trace-Log ('-' * 60)

## Calculating Build time
Expand Down
2 changes: 1 addition & 1 deletion src/NuGetGallery.Core/NuGetGallery.Core.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0"?>
<package >
<metadata>
<id>$id$</id>
<id>$PackageId$</id>
<version>$version$</version>
<title>$title$</title>
<authors>$author$</authors>
Expand Down