Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts visualization changes for package detailed stats #2687

Merged
merged 2 commits into from
Sep 24, 2015

Conversation

xavierdecoster
Copy link
Member

This PR changes the way charts are displayed for package detailed statistics.

Please review/comment @csharpfritz @yishaigalatzer @maartenba

Changes in this PR

  • Convert vertical bar chart to horizontal bar chart for group by client and group by operation. Note that group by package version remains a vertical bar chart, ordered by version, as the horizontal axis can be interpreted as a time dimension.
  • Make height of chart dynamic with a minimum bar height on horizontal bars, and respecting a minimum chart height when few bars
  • Added chart title to charts
  • Added data labels to horizontal bar charts
  • Moved "Total over the last 6 weeks" to top of the page and included it in the title, to have it positioned consistently independent of amount of data in the data grid below the chart
  • Moved last update time to the top of the page, to have it positioned consistently independent of amount of data in the data grid below the chart
  • Positioned chart above the pivot, to avoid having it "drop off" the page, and gain more space available to draw the chart

Screenshots

Group by Operation

Before
grouby-operation-old

After
grouby-operation-new

Group by Package Version

Before
grouby-operation-old

After
grouby-version-new

Group by Client Name

Before
grouby-client-old

After
grouby-client-new

@csharpfritz
Copy link

:shipit: -- this looks like info that marketing teams would like to see

@yishaigalatzer
Copy link

What is the second NuGet item? Can we please clarify it?

@xavierdecoster
Copy link
Member Author

@yishaigalatzer if you're referring to the second NuGet item in the group-by clientname table, I'd love to clarify those further :) The thing is NuGet clients send (and have sent) a wide range of different user agent headers, and I have no idea which (version of which) client used what. Who would be able to explain these in detail? https://github.com/NuGet/NuGet.Jobs/blob/master/src/Stats.ImportAzureCdnStatistics/knownclients.yaml#L38

I didn't change those values as I copied them from an existing sql function in the old warehouse. They're being served directly from the warehouse (except for 'Browsers' and 'Scripted Downloads' which are aggregations).

@maartenba
Copy link
Contributor

:shipit:

@xavierdecoster
Copy link
Member Author

@yishaigalatzer they're all NuGet.Core based downloads (some proxied, but still valid usage of NuGet.Core). This commit clarifies the label: NuGet/NuGet.Jobs@d7ceea9

This PR is about chart visualization changes which has two squirrels. I propose we merge it in and can discuss the NuGet.Core item in a separate thread :)

maartenba added a commit that referenced this pull request Sep 24, 2015
Charts visualization changes for package detailed stats
@maartenba maartenba merged commit cd4c0af into dev Sep 24, 2015
@maartenba maartenba deleted the stats-charts-update branch September 24, 2015 07:00
@maartenba maartenba mentioned this pull request Sep 24, 2015
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants