Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Picture on Profile Page #2657

Merged
merged 9 commits into from Sep 7, 2015
Merged

Profile Picture on Profile Page #2657

merged 9 commits into from Sep 7, 2015

Conversation

ghost
Copy link

@ghost ghost commented Sep 4, 2015

I change the logic for show the Gravatar in Profiles.cshtml.cs

Harrison Brock added 2 commits September 4, 2015 13:26
used localhost
changed confirmEailAddresses to false
@dnfclas
Copy link

dnfclas commented Sep 4, 2015

Hi @HBrock, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Sep 4, 2015

@HBrock, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@@ -6,9 +7,13 @@


@section SideColumn {
@if (String.IsNullOrEmpty(Model.EmailAddress))
@* Change to not null or empty *@
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is meant by this comment? Remove it if not needed.

@maartenba
Copy link
Contributor

Can you limit the PR to include just the src/NuGetGallery/Views/Users/Profiles.cshtml file that was updated?

@ghost
Copy link
Author

ghost commented Sep 4, 2015

Is there away I can limit it to just that one file for github?

@maartenba
Copy link
Contributor

That will need some git-fu. Here's what you could do:

  • revert your commits locally (keep a copy of the files you modified so you don't lose changes) - git revert HEAD~2 --hard will do
  • copy your changes back
  • do a selective commit of your changes that has only that file
  • git push --force (that's not recommended practice but in this case will do the trick)

@ghost
Copy link
Author

ghost commented Sep 4, 2015

The changes should be fixed...If I did not do anything wrong.

@ghost
Copy link
Author

ghost commented Sep 4, 2015

I seen I had an error with the last update. It should be working now.

@maartenba maartenba changed the title Dev Profile Pictore on Profile Page Sep 7, 2015
@maartenba maartenba changed the title Profile Pictore on Profile Page Profile Picture on Profile Page Sep 7, 2015
@maartenba maartenba merged commit 3b2b296 into NuGet:dev Sep 7, 2015
This was referenced Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants