Add client name translation #10134
Merged
Add client name translation #10134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 15, 2024 15:05
| @dataclass(frozen=True) | ||
| class ClientNames: | ||
| nuget: List[str] = field(default_factory=lambda: [ | ||
| "NuGet Cross-Platform Command Line", |
There was a problem hiding this comment.
Is this set coming from somewhere existing? Could you link to that existing place?
There was a problem hiding this comment.
It's coming from the C# version -- there were no unit tests to copy, so I took a sample and created some.
https://github.com/NuGet/NuGetGallery/blob/19ee5b18b0a7109df23705f1a8e2038d190708c6/src/Stats.LogInterpretation/ClientNames.cs
https://github.com/NuGet/NuGetGallery/blob/19ee5b18b0a7109df23705f1a8e2038d190708c6/src/Stats.LogInterpretation/ClientCategories.cs
https://github.com/NuGet/NuGetGallery/blob/19ee5b18b0a7109df23705f1a8e2038d190708c6/src/Stats.LogInterpretation/ClientNameTranslation.cs
erdembayar
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the
loginterpretationmodule, primarily focusing on adding new functionality for client name translation using dataclasses and enhancing test coverage. The most important changes include the introduction of dataclasses for client categories and names, the implementation of client name translation logic, and the addition of unit tests to validate the new functionality.Enhancements to Client Name Translation:
python/StatsLogParser/loginterpretation/clientnametranslation.py: IntroducedClientCategoriesandClientNamesdataclasses to categorize client names and implemented theClientNameTranslationclass with static methods for client name translation logic.Version Update:
python/StatsLogParser/pyproject.toml: Updated the version of theloginterpretationmodule from0.1.0to0.2.0.Test Coverage:
python/StatsLogParser/tests/test_clientnametranslation.py: Added unit tests usingpytestto validate theClientNameTranslationlogic, ensuring correct categorization of client names.