Add auth to V3 monitoring search cursor URLs #10115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the storage containers for our regional search instances are public. This is okay from a privacy standpoint (all of the content in there is public package metadata). But it is unnecessary. They are really internal storage accounts that should not have external callers. It will make our compliance simpler if we just lock these storage accounts down and use auth in the places that allow access.
Currently, this is our V3 monitoring pipeline, our cursor monitoring system (Synthetics), and NuGet Insights.
Progress on https://github.com/NuGet/Engineering/issues/5576.
This PR adds support for using SAS or managed identity for accessing the Azure Search cursor URLs in the V3 monitoring pipeline.
Summary of changes:
AzureBlobCursor
which is aReadCursor
implementation usingBlobClient
. This allows auth'd scenarios.-searchCursorSasValue-*
and-searchCursorUseManagedIdentity-*
arguments to MonitoringProcessor and CatalogToMonitoring so that credentials can be plumbed in for accessing the search cursors.SearchEndpointConfiguration
and related types to allow the various search cursor read scenarios.CommandHelpers
.