Fetch and copy HTTP headers if they are being updated #10101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyjdev
previously approved these changes
Aug 1, 2024
erdembayar
reviewed
Aug 1, 2024
This reverts commit 8ca9e56.
erdembayar
approved these changes
Aug 1, 2024
drewgillies
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will also copy this implementation to ServerCommon. Great catch by @dannyjdev!
Without this, we loose any additional HTTP headers existing on the blob, not overridden on the
BlobHttpHeadersinstance.SetHttpHeadersAsyncreplaces ALL headers that can possible be set by it, not just the ones you explicitly assign.Also, unrelated, remove a BuildConfiguration parameter from the CI YAML. Perhaps that is what is preventing the automatic CI build from working. (it's a guess, it's something I added as a nicety but it's not required at this time)