Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dark Mode] Fix table row colors in dark mode #10096

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[Dark Mode] Fix table row colors in dark mode #10096

merged 1 commit into from
Aug 1, 2024

Conversation

martinrrm
Copy link
Contributor

Wrong style for some table rows in the package readme section.

Before

image

After

image
image

Addresses #10065

@martinrrm martinrrm requested a review from a team as a code owner July 31, 2024 18:47
@martinrrm martinrrm marked this pull request as draft July 31, 2024 18:47
@martinrrm martinrrm changed the base branch from main to dev July 31, 2024 18:47
@martinrrm martinrrm force-pushed the dev-martinrrm-fix-table-colors-dark-theme branch from 5f1e8ba to 16db688 Compare July 31, 2024 18:48
@martinrrm martinrrm marked this pull request as ready for review July 31, 2024 18:48
@erdembayar
Copy link
Contributor

Please add repair work item link?

erdembayar
erdembayar approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@erdembayar erdembayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

drewgillies
drewgillies approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@drewgillies drewgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@martinrrm
Copy link
Contributor Author

Is the CI really running? 😟

@martinrrm martinrrm merged commit ec3c8d2 into dev Aug 1, 2024
2 checks passed
@joelverhagen joelverhagen deleted the dev-martinrrm-fix-table-colors-dark-theme branch August 1, 2024 16:56
@joelverhagen joelverhagen mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erdembayar erdembayar erdembayar approved these changes

@drewgillies drewgillies drewgillies approved these changes

@zhhyu zhhyu zhhyu approved these changes

@advay26 advay26 advay26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinrrm @erdembayar @drewgillies @zhhyu @advay26