Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Redesign] Alerts in README tab have extra space #8729

Closed
loic-sharma opened this issue Aug 2, 2021 · 1 comment
Closed

[Redesign] Alerts in README tab have extra space #8729

loic-sharma opened this issue Aug 2, 2021 · 1 comment
Assignees
@loic-sharma @dannyjdev
Labels
Verified-Dev Verified-Int
Milestone
Sprint 2021-08

Comments

@loic-sharma
Copy link
Contributor

Each tab is supposed to have 30px of margin before the content starts:

image

However, the README tab content has 45px of margin if the content starts with an alert:

image
@loic-sharma loic-sharma added this to the Sprint 2021-08 milestone Aug 2, 2021
@loic-sharma loic-sharma mentioned this issue Aug 2, 2021
Merged
loic-sharma added a commit that referenced this issue Aug 3, 2021
@loic-sharma
[Redesign] Remove extra space on README warnings (#8730)
3878f53 
Addresses #8729
@loic-sharma
Copy link
Contributor Author

@dannyjdev You can verify this by logging in as admin and browsing the README tab for any package that does not have a README. You should see a warning that the description is shown instead. This warning should not have too much space above it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loic-sharma loic-sharma

@dannyjdev dannyjdev

Labels
Verified-Dev Verified-Int
Projects
None yet
Milestone
Sprint 2021-08
Development

No branches or pull requests
2 participants
@loic-sharma @dannyjdev