Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide faster feedback to package author when uploaded package does not match signature requirements #6181

Closed
joelverhagen opened this issue Jul 18, 2018 · 1 comment

Comments

@joelverhagen
Copy link
Member

@joelverhagen commented on Tue Jul 17 2018

When a package must be signed, we can quickly reject an unsigned version by checking for the presence of a signature file.

When a package must not be signed, we can quickly reject a signed version by checking for the presence of a signature file.

Both operations are safe to be done in gallery process.


@joelverhagen commented on Tue Jul 17 2018

I need text for both cases and for both the upload flow and the command line push flow.

/cc @anangaur

@joelverhagen
Copy link
Member Author

joelverhagen commented Jul 23, 2018

Proposed strings for both web UI and command line.

When publishing an unsigned package and signing is required:

This package must be signed with a registered certificate.

When publishing a signed package and no certificate is configured.

The package was signed. You must register the signing certificate to publish signed packages.

@anangaur?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants