Skip to content

Commit

Permalink
Do not CC sender for Contact Owners emails
Browse files Browse the repository at this point in the history
  • Loading branch information
Scott Bommarito committed Oct 30, 2018
1 parent 6ebb7a2 commit c6e3c47
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
8 changes: 4 additions & 4 deletions src/NuGetGallery.Core/NuGetGallery.Core.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,10 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="NuGet.Services.Entities">
<Version>2.30.0</Version>
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Messaging">
<Version>2.30.0</Version>
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.StrongName.AnglicanGeek.MarkdownMailer">
<Version>1.2.0</Version>
Expand Down Expand Up @@ -242,10 +242,10 @@
<Version>4.8.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Validation">
<Version>2.30.0</Version>
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Validation.Issues">
<Version>2.30.0</Version>
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="WindowsAzure.Storage">
<Version>7.1.2</Version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public BackgroundMarkdownMessageService(
private Func<BackgroundMarkdownMessageService> _messageServiceFactory;
private bool _sentMessage;

protected override Task SendMessageInternalAsync(MailMessage mailMessage, bool copySender = false, bool discloseSenderAddress = false)
protected override Task SendMessageInternalAsync(MailMessage mailMessage)
{
// Some MVC controller actions send more than one message. Since this method sends
// the message async, we need a new IMessageService per email, to avoid calling
Expand All @@ -39,7 +39,7 @@ protected override Task SendMessageInternalAsync(MailMessage mailMessage, bool c
if (_sentMessage)
{
var newMessageService = _messageServiceFactory.Invoke();
return newMessageService.SendMessageInternalAsync(mailMessage, copySender, discloseSenderAddress);
return newMessageService.SendMessageInternalAsync(mailMessage);
}
else
{
Expand All @@ -55,7 +55,7 @@ protected override Task SendMessageInternalAsync(MailMessage mailMessage, bool c
{
try
{
await base.SendMessageInternalAsync(messageCopy, copySender, discloseSenderAddress);
await base.SendMessageInternalAsync(messageCopy);
}
catch (Exception ex)
{
Expand Down
14 changes: 7 additions & 7 deletions src/NuGetGallery/NuGetGallery.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -1977,13 +1977,13 @@
<Version>0.15.4</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Entities">
<Version>2.30.0</Version>
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Messaging">
<Version>2.30.0</Version>
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Messaging.Email">
<Version>2.30.0</Version>
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.StrongName.AnglicanGeek.MarkdownMailer">
<Version>1.2.0</Version>
Expand Down Expand Up @@ -2210,16 +2210,16 @@
<Version>4.8.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.KeyVault">
<Version>2.30.0</Version>
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Logging">
<Version>2.30.0</Version>
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Owin">
<Version>2.30.0</Version>
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="NuGet.Services.Sql">
<Version>2.30.0</Version>
<Version>2.31.0</Version>
</PackageReference>
<PackageReference Include="Owin">
<Version>1.0.0</Version>
Expand Down

0 comments on commit c6e3c47

Please sign in to comment.