This repository was archived by the owner on Jul 30, 2024. It is now read-only.
Added EventName property to the PackageValidationAuditEntry #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… distinguish between types of the entries.
|
@agr, |
skofman1
reviewed
Apr 24, 2017
|
|
||
| namespace NuGet.Jobs.Validation.Common | ||
| { | ||
| public static class ValidationEvent |
There was a problem hiding this comment.
Consider turning this into enums
There was a problem hiding this comment.
If you're concerned about the human readability of having an enum, I would suggest having two fields
{
"ValidatorName": "validator-unzip",
"Message": "Found 4 parts in package.",
"Timestamp": "2017-03-31T22:09:00.7356706+00:00"
"EventId": 1,
"EventName": "BeforeVirusScan"
}
dtivel
approved these changes
Apr 24, 2017
| @@ -0,0 +1,71 @@ | |||
| using System; | |||
scottbommarito
approved these changes
Apr 24, 2017
|
|
||
| namespace NuGet.Jobs.Validation.Common | ||
| { | ||
| public static class ValidationEvent |
There was a problem hiding this comment.
If you're concerned about the human readability of having an enum, I would suggest having two fields
{
"ValidatorName": "validator-unzip",
"Message": "Found 4 parts in package.",
"Timestamp": "2017-03-31T22:09:00.7356706+00:00"
"EventId": 1,
"EventName": "BeforeVirusScan"
}
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Added EventName property to the PackageValidationAuditEntry to easier distinguish between types of the entries. * Added copyright header * Changed ValidationEvent to enum.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the #405.
Needed a way to easily distinguish between audit entries for the monitoring.