This repository was archived by the owner on Jul 30, 2024. It is now read-only.
Added logging of the request body when scanning request was marked as failed #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agr, |
src/Validation.Common/TraceHelper.cs
Outdated
| $"{{{TraceConstant.ValidatorName}}} " + | ||
| $"ValidationId: {{{TraceConstant.ValidationId}}} " + | ||
| $"for package {{{TraceConstant.PackageId}}} " + | ||
| $"v.{{{TraceConstant.PackageVersion}}} " + |
There was a problem hiding this comment.
Non-standard to prepend v.. {id} {version} is fine.
| @@ -230,7 +241,7 @@ public void Configuration(IAppBuilder app) | |||
| validationEntity.ValidatorCompleted(VcsValidator.ValidatorName, ValidationResult.Failed); | |||
| await _packageValidationTable.StoreAsync(validationEntity); | |||
|
|
|||
| _logger.TrackValidatorResult(VcsValidator.ValidatorName, validationId, ValidationResult.Failed.ToString(), validationEntity.PackageId, validationEntity.PackageVersion); | |||
| _logger.TrackValidatorResult(VcsValidator.ValidatorName, validationId, ValidationResult.Failed.ToString(), validationEntity.PackageId, validationEntity.PackageVersion, body.Substring(0, ReasonableBodySize)); | |||
There was a problem hiding this comment.
Please append "(truncated)" when you truncate.
Will be able to see the full request body in blob storage?
There was a problem hiding this comment.
Added "(truncated)", put full body into blob.
Made body completely logged in audit blob.
joelverhagen
approved these changes
Apr 21, 2017
joelverhagen
added a commit
that referenced
this pull request
Sep 27, 2019
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
… failed (#131) * Added logging of the request body when scanning request was marked as failed. * Removed "v." * Added method to truncate string. Made body completely logged in audit blob.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging more info for failed scans, to make investigations easier. #398