Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.
/ NuGet.Jobs Public archive

Clean up build infra to make a repository merge easier #1217

Merged
merged 17 commits into from
Jul 23, 2024

Conversation

joelverhagen
Copy link
Member

@joelverhagen joelverhagen commented Jul 20, 2024

Just like NuGet/ServerCommon#434 but for Jobs.

I would like to try a repository merge (monorepo-ish). That is, merging NuGet Server OSS repositories into fewer (perhaps just one). To make this easier, I want to clean up and align our build infra, which is a case where the same file names exist in several repos, making a repo merge have merge conflicts.

Summary of changes

  • Bring .editorconfig from NuGetGallery. This appears to be the latest and greatest.
  • Update .gitignore to latest
  • Delete .gitattributes, it was useless
  • Update .nuget/packages.config (solution level packages) to match NuGetGallery, move to root for better visibility
  • Rename SimpleVersion and SemanticVersion to JobsAssemblyVersion and JobsPackageVersion
  • Fix some PowerShell functions to use allowed verbs
  • Delete build.cmd, buildandtest.ps1, restoreNuGetExe.ps1 since these are not used by our CI at all.
  • In build.ps1 and test.ps1 sort project specific paths and make them more DRY
  • More some stuff from SdkProjects.props to Directory.Build.props
  • Latest Xunit has a lot of helpful analyzers. I fixed all of the associated warnings which made the diff bigger.

@joelverhagen joelverhagen requested a review from a team as a code owner July 20, 2024 21:54
# Conflicts:
#	.editorconfig
#	Directory.Packages.props
#	test.ps1
@joelverhagen joelverhagen reopened this Jul 23, 2024
@joelverhagen joelverhagen merged commit 72f99d3 into dev Jul 23, 2024
2 checks passed
@joelverhagen joelverhagen deleted the jver-standardize branch July 23, 2024 22:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants