Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CPM for OptProf tests #5598

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Disable CPM for OptProf tests #5598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/NuGet.Tests.Apex/NuGet.OptProf/Assets/PackageReferenceSdk/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
<Project />
Copy link
Contributor

@kartheekp-ms kartheekp-ms Jan 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be the best option would have been to delete the Directory.Packages.props file completely because there are no properties defined in it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run the test from VS, or dotnet test on the CLI, I'm worried it might find the repo root Directory.Packages.props. I assume that's why the file was added in the first place. There are also empty Directory.Build.props and targets files in the same directory.

<Project>
<PropertyGroup>
<ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally>
</PropertyGroup>
</Project>