edk2-uefi-shell: fix cross compilation #364044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PYTHON_COMMAND workaround was introduced in NixOS#201095, but it does not seem to have caused issues so far, until the version update in bef3f40. Not sure why this was not an issue before this update and why it is now, but I think this fix makes sense regardless of the exact root cause, and I don't think it's worth the effort to dig further.
kuruczgy
force-pushed
the
pr/fix-edk2-cross
branch
from
d6916e8 to
6e6b17b
Compare
github-actions
bot
added
10.rebuild-darwin: 0
2 tasks
mjoerg
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Thanks!
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 364044
x86_64-linux
aarch64-linux
x86_64-darwin
aarch64-darwin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PYTHON_COMMAND workaround was introduced in #201095, but it does not seem to have caused issues so far, until the version update in bef3f40. Not sure why this was not an issue before this update and why it is now, but I think this fix makes sense regardless of the exact root cause, and I don't think it's worth the effort to dig further.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.