Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages: 17.0.6 -> 18.1.5 on other platforms #312617

Merged
merged 1 commit into from
Jun 27, 2024
Merged

llvmPackages: 17.0.6 -> 18.1.5 on other platforms #312617

merged 1 commit into from
Jun 27, 2024

Conversation

alyssais
Copy link
Member

Description of changes

This is supposed to be kept at the latest version.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alyssais
llvmPackages: 17.0.6 -> 18.1.5 on other platforms
8fc728c 
This is supposed to be kept at the latest version.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 18, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 18, 2024
@rrbutani rrbutani mentioned this pull request May 20, 2024
Merged
13 tasks
@rrbutani rrbutani added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label May 23, 2024
@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels May 23, 2024
@alyssais
Copy link
Member Author

@sternenseemann it looks like LLVM 18 can't build itself with pkgsLLVM. Do you think there's anything that can be done about that? How important is it?

@sternenseemann
Copy link
Member

@alyssais ncurses is failing, right? I guess a lot of the package set will be broken, but there's no requirement to build the host llvmPackages for the pkgsLLVM stdenv.

@alyssais
Copy link
Member Author

No. When building the stdenv for the host platform, compiler-rt fails to build.

@rrbutani
Copy link
Contributor

rrbutani commented May 24, 2024 •
edited
Loading

@alyssais Can you share what package you're building/on what host architecture?

I'm happy to look into the build issues but I'm having trouble reproducing; pkgsLLVM.llvmPackages_18.compiler-rt builds fine for me (on x86_64-linux with this PR and #312981 applied).

EDIT: I do run into linker errors when building pkgsLLVM.llvmPackages_18.libcxx; is this what you were seeing?

x86_64-unknown-linux-gnu-ld: error: undefined symbol: __divti3

@alyssais
Copy link
Member Author

Oh yes, sorry, I meant libcxx.

@paparodeo
Copy link
Contributor

paparodeo commented May 24, 2024 •
edited
Loading

EDIT: I do run into linker errors when building pkgsLLVM.llvmPackages_18.libcxx; is this what you were seeing?

x86_64-unknown-linux-gnu-ld: error: undefined symbol: __divti3

llvm18+ libcxx needs to link to libc as stated #292043 (it was git then) which is why
5373083#diff-52490149132ec29e0b5e70244f01f064580405a4e15bafff8c71f22e8d2779c7R57-R64

doesn't contain

    "-DCMAKE_EXE_LINKER_FLAGS=-nostdlib"
    "-DCMAKE_SHARED_LINKER_FLAGS=-nostdlib"

but it seems like it was dropped re-added when the files were unified

@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
@alyssais
Copy link
Member Author

alyssais commented Jun 4, 2024

That fix was made in d0b08ab. I'm not aware of any other build regressions. Would any pkgsLLVM users like to check their use cases still work with the update to 18, either with this PR or #312981?

@alyssais alyssais merged commit da3789a into NixOS:master Jun 27, 2024
25 checks passed
@alyssais alyssais deleted the llvmPackages-18-other branch June 27, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrbutani rrbutani rrbutani approved these changes

@wegank wegank wegank approved these changes

@RossComputerGuy RossComputerGuy RossComputerGuy approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

@dtzWill dtzWill Awaiting requested review from dtzWill

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alyssais @sternenseemann @rrbutani @paparodeo @wegank @RossComputerGuy