edk2: fix build on x86_64-darwin

[reckenrode]

ZHF #199919

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[RaitoBezarius]

LGTM as we were already hardcoding LLVM toolchain.

[reckenrode]

I ended up adding OVMF and edk2-uefi-shell to the PR since they depend on edk2. I can split them out, but the separate PRs wouldn’t be buildable until this one landed.

[RaitoBezarius]

Seems fair to me.

[mweinelt]

Can someone check why ofBorg is unhappy?

[RaitoBezarius]

Can someone check why ofBorg is unhappy?

For Darwin:

xcode-select: error: no developer tools were found at '/Applications/Xcode.app', and no install could be requested (perhaps no UI is present), please install manually from 'developer.apple.com'.

It seems unrelated to the PR and more an ofborg issue itself.

For aarch64-linux, just after VM boot, the command pipe is broken, I do not have aarch64 to reproduce, but it could be some regression due to this PR building a corrupted OVMF firmware, we should investigate.

[reckenrode]

Looking at the full log, there’s a message about running out of space. Is that expected?

[Errno 28] No space left on device: '/nix/store/dg7z7wnyy2wv1w97vqm946z9fr2y6n0l-initrd-linux-5.15.77/initrd' -> '/boot/efi/nixos/dg7z7wnyy2wv1w97vqm946z9fr2y6n0l-initrd-linux-5.15.77-initrd.efi'

[RaitoBezarius]

Looking at the full log, there’s a message about running out of space. Is that expected?

[Errno 28] No space left on device: '/nix/store/dg7z7wnyy2wv1w97vqm946z9fr2y6n0l-initrd-linux-5.15.77/initrd' -> '/boot/efi/nixos/dg7z7wnyy2wv1w97vqm946z9fr2y6n0l-initrd-linux-5.15.77-initrd.efi'

This is a classical issue with these macOS builders I think, cc @grahamc

[LunNova]

@reckenrode edk2-uefi-shell still seems to be failing on hydra for aarch64-darwin. I don't have a darwin machine, are you able to look into it?

[reckenrode]

@LunNova I’ll take a look at it. The other edk2 packages don’t support aarch64-darwin, so the fix may be to limit edk2-uefi-shell similarly.

[reckenrode]

I checked the job report for nixpkgs-22.05-darwin, but I don’t see any failures for edk2-uefi-shell. It also won’t build locally due to being an unsupported platform, which is what I should expect. Can you help point me in the right direction to where you’re seeing the failure on Hydra?

[LunNova]

Sorry that should've been x86_64-darwin not arrch64-darwin.

https://hydra.nixos.org/build/198166720

[RaitoBezarius]

Sorry that should've been x86_64-darwin not arrch64-darwin.

https://hydra.nixos.org/build/198166720

It really seems to be an orthogonal issue due to the Apple environment, I think.

[reckenrode]

I was able to reproduce the problem by disabling sandboxing. edksetup.sh uses whereis to locate Python, which picks up /usr/bin/python3 when sandboxing is disabled on Darwin. I opened #201095 with a fix.