Increase max IPv4 clientid. #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsmarples
reviewed
Feb 3, 2025
Remove arbitrary limit, raising to the maximum representable by uint8
All DHCP options have a limit of 255 bytes, so just define that rather than each option we want to parse. Only the hostname option is NUL terminated, the others store an extra leading byte to state the data length. Process the to the size of the storage, not a predifined length incase we change it again in the future. More for NetworkConfiguration#435. Note that for parse_hwaddr, we set the first byte to zero if we cannot process arg as a hardware address to indicate that the data should be treated as a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove arbitrary limit, raising to the maximum representable by uint8
As discussed in #435