Decompiler: Add support for INT_REM in jumptable recovery. #6070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumbel
reviewed
Dec 30, 2023
This commit adds INT_REM handling to JumpBasic, which allows switch statements depending on expressions like "x % 10" to be properly recovered. Previously, a warning was emitted about there being "too many branches".
LukeSerne
force-pushed
the
decomp-jumptable-recovery-add-int-rem
branch
from
7da9f4f to
1cae319
Compare
ryanmkurtz
added
Feature: Decompiler
Status: Triage
|
This won't help with my case... sniff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
INT_REMhandling to theJumpBasicclass, which allows switch statements depending on expressions likex % 10to be properly recovered. Previously, a warning was emitted about there being "too many branches". This slightly improves the third problem mentioned in #2628 (comment).Screenshots
These screenshots show the
mainfunction of theswitchexample fromGhidraDocs/GhidraClass/Advanced/Examplesafter auto-analysis.Before applying the patch
After applying the patch
