Support building NCCL with RDMA-core [part 2 of 2]: NCCL_BUILD_RDMA_CORE #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtlam
changed the title
sjeaugey
reviewed
Mar 20, 2023
src/misc/ibvwrap.cc
Outdated
| @@ -21,11 +21,16 @@ ncclResult_t wrap_ibv_symbols(void) { | |||
| } | |||
|
|
|||
| /* CHECK_NOT_NULL: helper macro to check for NULL symbol only with dynamic loading */ | |||
| #ifdef NCCL_BUILD_RDMA_CORE | |||
| #define CHECK_NOT_NULL(container, internal_name) | |||
There was a problem hiding this comment.
I'm not sure we even need that. If the check is defined as a no-op, then it means we consider the function pointer cannot be NULL, and therefore the check will always be ok. Unless, that is to optimize performance?
There was a problem hiding this comment.
Yep, that is for performance. Certain verb calls (e.g., ibv_post_send(), ibv_post_recv(), ibv_poll_cq()) can happen quite frequently. That said, I am ok with removing it if you have a strong opinion on pointer safety.
sjeaugey
added a commit
that referenced
this pull request
Apr 19, 2023
Add support for IB SHARP to NVLS (NVLink SHARP algorithm). Add NVLS+Tree algorithm. Add support for memory management using cuMem* functions. Use all NICs for Send/Receive operations on systems with more than one NIC per GPU (#804). Add ncclCommSplit primitive, with resource sharing option in config. Fix alltoallv hang (#788) Increase number of channels on H100 when we're not limited by NVLink. Improve error reporting in case of IB failure, printing local and remote ID (#779). Add build option to allow compilation against RDMA includes instead of dynamically loading IB verbs symbols (#802). Fix context creation for progress thread (#803). NET/IB: add option to use multiple QPs in round-robin mode. Fix tree performance issue when NVB is disabled on HCM topologies.
|
This has been added as part of NCCL 2.19.3. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.